feat: compute storage root #1294
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enitrat
force-pushed
the
feat/storage-root
branch
from
5e9917b
to
51532b9
Compare
Comment on lines
+29
to
+38
| let base = 0x10; | ||
| let bound = 0x10; | ||
| let (high, _) = unsigned_div_rem(value, base); | ||
| assert [output] = high; | ||
| let output = output + 1; | ||
| %{ | ||
| memory[ids.output] = res = (int(ids.value) % PRIME) % ids.base | ||
| assert res < ids.bound, f'split_int(): Limb {res} is out of range.' | ||
| %} | ||
| let output = output + 1; |
There was a problem hiding this comment.
why not just ?
Suggested change
| let base = 0x10; | |
| let bound = 0x10; | |
| let (high, _) = unsigned_div_rem(value, base); | |
| assert [output] = high; | |
| let output = output + 1; | |
| %{ | |
| memory[ids.output] = res = (int(ids.value) % PRIME) % ids.base | |
| assert res < ids.bound, f'split_int(): Limb {res} is out of range.' | |
| %} | |
| let output = output + 1; | |
| let (high, low) = unsigned_div_rem(value, 0x10); | |
| assert [output] = high; | |
| assert [output + 1] = low; | |
| let output = output + 2; |
Comment on lines
+40
to
+53
| let nibbles_len = [fp]; | ||
| let output_start = cast([fp + 1], felt*); | ||
| let count = output - output_start; | ||
| let is_done = Helpers.is_zero(nibbles_len - count); | ||
| jmp done if is_done != 0; | ||
|
|
||
| let next_byte_index = count / 2; | ||
| let bytes = cast([fp - 3], felt*); | ||
| tempvar value = bytes[next_byte_index]; | ||
| let range_check_ptr = range_check_ptr + 1; | ||
| [ap] = range_check_ptr, ap++; | ||
| [ap] = output, ap++; | ||
| [ap] = value, ap++; | ||
|
|
There was a problem hiding this comment.
this can be simplified to avoid the is_zero calls especially
| let prefix = ((2 * is_leaf) + 1) * 16 + self.nibbles[0]; | ||
| assert encoded[0] = prefix; | ||
| tempvar to_pack = new Nibbles(self.nibbles_len - 1, self.nibbles + 1); | ||
| let bytes_len = NibblesImpl.pack_nibbles(to_pack, encoded + 1); |
There was a problem hiding this comment.
Suggested change
| let bytes_len = NibblesImpl.pack_nibbles(to_pack, encoded + 1); | |
| let bytes_len = pack_nibbles(to_pack, encoded + 1); |
| // Case even number of nibbles | ||
| let prefix = 2 * is_leaf * 16; | ||
| assert encoded[0] = prefix; | ||
| let bytes_len = NibblesImpl.pack_nibbles(self, encoded + 1); |
There was a problem hiding this comment.
Suggested change
| let bytes_len = NibblesImpl.pack_nibbles(self, encoded + 1); | |
| let bytes_len = pack_nibbles(self, encoded + 1); |
src/utils/mpt/nibbles.cairo
Outdated
| return bytes_len; | ||
| } | ||
|
|
||
| func encode_path{range_check_ptr}(self: Nibbles*, is_leaf: felt) -> ( |
There was a problem hiding this comment.
so this is mainly packing the nibbles with a prefix. It gives me the impression that we go from bytes* to nibbles* to bytes* again, not sure to understand
obatirou
reviewed
Jul 25, 2024
| let (local output: felt*) = alloc(); | ||
|
|
||
| if (nibbles_len == 0) { | ||
| tempvar res = new Nibbles(nibbles_len, output); |
There was a problem hiding this comment.
in done label: new Nibbles(nibbles_len, nibbles);
Maybe standardize the naming of what Nibbles takes by renaming output to nibbles or changing the naming in done label?
obatirou
reviewed
Jul 25, 2024
| from utils.mpt.nibbles import Nibbles, NibblesImpl | ||
|
|
||
| func test__from_bytes{range_check_ptr}() -> Nibbles* { | ||
| // Given |
There was a problem hiding this comment.
to remove if not following given / when / then
enitrat
force-pushed
the
feat/storage-root
branch
from
c40206a
to
4eda303
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time spent on this PR: tbd
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Resolves #1243
What is the new behavior?
This change is